Skip to content

Commit

Permalink
refactor #404 Changing the config key as suggested by pamil #190 (mam…
Browse files Browse the repository at this point in the history
…azu)

This PR was merged into the 1.0-dev branch.

Discussion
----------

THIS IS A BC BREAK and needs to be documented. (How?)

Commits
-------

a230061 Changing the config key as suggested by pamil #190
5b01254 Fixed it in the README
ddb9c63 Adding upgrade.md comment
  • Loading branch information
lchrusciel authored Mar 22, 2019
2 parents a4b2f62 + ddb9c63 commit b1ee76e
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,9 @@ The latest documentation is available [here](https://app.swaggerhub.com/apis/Syl

### Attributes

If you would like to receive serialized attributes you need to define an array of theirs codes under `shop_api.included_attributes` key. E.g.
If you would like to receive serialized attributes you need to define an array of theirs codes under `sylius_shop_api.included_attributes` key. E.g.
```yml
shop_api:
sylius_shop_api:
included_attributes:
- "MUG_MATERIAL_CODE"
```
Expand Down
3 changes: 3 additions & 0 deletions UPGRADE.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# UPGRADE FROM 1.0.0-beta.18 to 1.0.0-beta.20
* The configuration key for the shop api is now `sylius_shop_api`.

# UPGRADE FROM 1.0.0-beta.17 to 1.0.0-beta.18

* Customer registration payload changed:
Expand Down
2 changes: 1 addition & 1 deletion src/DependencyInjection/Configuration.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ final class Configuration implements ConfigurationInterface
public function getConfigTreeBuilder()
{
$treeBuilder = new TreeBuilder();
$rootNode = $treeBuilder->root('shop_api');
$rootNode = $treeBuilder->root('sylius_shop_api');

$this->buildIncludedAttributesNode($rootNode);
$this->buildViewClassesNode($rootNode);
Expand Down

0 comments on commit b1ee76e

Please sign in to comment.