Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Doctrine processors #581

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Add Doctrine processors #581

merged 2 commits into from
Feb 16, 2023

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Jan 30, 2023

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
License MIT

@loic425 loic425 requested a review from a team as a code owner January 30, 2023 13:42
@loic425 loic425 force-pushed the feature/doctrine-processor branch from d85954b to 80cf65d Compare January 30, 2023 14:42
@loic425 loic425 force-pushed the feature/doctrine-processor branch from 80cf65d to a97e443 Compare January 31, 2023 07:37
@loic425 loic425 changed the title [WIP] Add Doctrine processors Add Doctrine processors Jan 31, 2023
@loic425 loic425 force-pushed the feature/doctrine-processor branch 5 times, most recently from 5d9e750 to d8fcd14 Compare February 4, 2023 13:50
@loic425 loic425 force-pushed the feature/doctrine-processor branch from d8fcd14 to 9b2b02b Compare February 8, 2023 20:01
@loic425 loic425 force-pushed the feature/doctrine-processor branch from 9b2b02b to 944de7b Compare February 14, 2023 12:30
lchrusciel
lchrusciel reviewed Feb 16, 2023
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are lacking tests for all new classes from this PR :/

...nent/Doctrine/Common/Metadata/Resource/Factory/DoctrineResourceMetadataCollectionFactory.php
use Sylius\Component\Resource\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface;
use Sylius\Component\Resource\Metadata\Resource\ResourceMetadataCollection;

class DoctrineResourceMetadataCollectionFactory implements ResourceMetadataCollectionFactoryInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't you finalized this class? Is there a proxy created from it?

Suggested change
class DoctrineResourceMetadataCollectionFactory implements ResourceMetadataCollectionFactoryInterface
final class DoctrineResourceMetadataCollectionFactory implements ResourceMetadataCollectionFactoryInterface

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no, that's a mistake

@lchrusciel lchrusciel added Feature New feature proposals. DX Issues and PRs aimed at improving Developer eXperience. labels Feb 16, 2023
@lchrusciel lchrusciel merged commit f9dc633 into Sylius:poc-new-resource-metadata Feb 16, 2023
@loic425 loic425 deleted the feature/doctrine-processor branch February 17, 2023 08:01
@loic425 loic425 mentioned this pull request Mar 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience. Feature New feature proposals.
Projects
Resource & Grid new architecture
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loic425 @lchrusciel