Main request #385
Closed
Main request #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't it a BC break ? I mean, some classes are not final, so introducing a return type should be BC break. Or am I wrong ? |
|
@Roshyo no, since PHP 7.4 there's full covariance support: https://www.php.net/manual/en/language.oop5.variance.php#language.oop5.variance.covariance |
Roshyo
reviewed
Mar 29, 2022
| * @return QueryBuilder | ||
| */ | ||
| protected function getCollectionQueryBuilder() | ||
| protected function getCollectionQueryBuilder(): QueryBuilder\ |
There was a problem hiding this comment.
Is that trailing \ desired ?
| @@ -28,14 +28,11 @@ class DefaultParentListener | |||
| /** @var DocumentManagerInterface */ | |||
| private $documentManager; | |||
There was a problem hiding this comment.
Why not enforcing this one too ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of #332 to 1.8 branch