Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPDoc typo in Component\Resource\Model\TranslatableInterface #371

Closed
dbyk opened this issue Feb 25, 2022 · 0 comments · Fixed by #378
Closed

PHPDoc typo in Component\Resource\Model\TranslatableInterface #371

dbyk opened this issue Feb 25, 2022 · 0 comments · Fixed by #378

Comments

@dbyk
Copy link

dbyk commented Feb 25, 2022

Sylius docs version: 1.x / latest
https://github.com/Sylius/SyliusResourceBundle/blob/master/src/Component/Model/TranslatableInterface.php#L21

Description
There's a PHPDoc block in public function getTranslations(): Collection in TranslatableInterface
The method returns TranslationInterface[], but the first PHPDoc section states @return Collection|TranslatableInterface[]

Forced us to add PHPDoc in our code for proper type hints.
@dannyvw dannyvw mentioned this issue Mar 12, 2022
Merged
Zales0123 added a commit that referenced this issue Mar 14, 2022
@Zales0123
bug #378 Fix phpdoc for getTranslations (dannyvw)
2949002 
This PR was merged into the 1.9-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no <!-- don't forget to update the UPGRADE-*.md file -->
| Related tickets | fixes #371
| License         | MIT


Commits
-------

bb28c34 Fix phpdoc for getTranslations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix phpdoc for getTranslations dannyvw/SyliusResourceBundle
1 participant
@dbyk