Skip to content

Commit

Permalink
refactor #204 Replace AbstractController with ControllerTrait & Conta…
Browse files Browse the repository at this point in the history
…inerAwareInterface (pamil)

This PR was merged into the 1.7-dev branch.

Discussion
----------

We can't use `AbstractController` if we want to keep BC - `AbstractController` requires a service locator with predefined dependencies and `ResourceController` requires a container with all public services for BC purposes.

Commits
-------

3cf7a05 Replace AbstractController with ControllerTrait & ContainerAwareInterface
  • Loading branch information
pamil authored Oct 15, 2020
2 parents 671d393 + 3cf7a05 commit 71da2eb
Show file tree
Hide file tree
Showing 7 changed files with 465 additions and 10 deletions.
1 change: 1 addition & 0 deletions easy-coding-standard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ services:

parameters:
exclude_files:
- 'src/Bundle/Controller/ControllerTrait.php'
- 'src/Bundle/test/app/cache/*'
- 'src/Bundle/test/var/*'

Expand Down
1 change: 1 addition & 0 deletions phpstan.neon
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ parameters:
reportUnmatchedIgnoredErrors: false

excludes_analyse:
- %currentWorkingDirectory%/src/Bundle/Controller/ControllerTrait.php
- %currentWorkingDirectory%/src/Bundle/DependencyInjection/Configuration.php
- %currentWorkingDirectory%/src/Bundle/DependencyInjection/PagerfantaConfiguration.php
- %currentWorkingDirectory%/src/Bundle/DependencyInjection/Driver/Doctrine/DoctrineODMDriver.php
Expand Down
1 change: 1 addition & 0 deletions psalm.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
<directory name="src/Bundle/Tests" />
<directory name="src/Component/spec" />
<directory name="src/Component/vendor" />
<file name="src/Bundle/Controller/ControllerTrait.php" />
<file name="src/Bundle/DependencyInjection/Driver/Doctrine/DoctrineODMDriver.php" />
<file name="src/Bundle/DependencyInjection/Driver/Doctrine/DoctrinePHPCRDriver.php" />
<file name="src/Bundle/EventListener/ODM*.php" />
Expand Down
Loading

0 comments on commit 71da2eb

Please sign in to comment.