Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build by creating better tests #7

Merged
merged 1 commit into from
Jul 5, 2019
Merged

Fix the build by creating better tests #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 37 additions & 3 deletions src/Component/spec/FieldTypes/StringFieldTypeSpec.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,45 @@ function it_escapes_string_values(DataExtractorInterface $dataExtractor, Field $
$this->render($field, ['foo' => 'bar'], [])->shouldReturn('<i class="book icon"></i>');
}

function it_does_not_escape_non_string_values(DataExtractorInterface $dataExtractor, Field $field): void
function it_casts_objects_to_string(DataExtractorInterface $dataExtractor, Field $field): void
{
$data = new \stdClass();
$data = new class {
public function __toString(): string {
return 'Value';
}
};

$dataExtractor->get($field, ['foo' => 'bar'])->willReturn($data);
$this->render($field, ['foo' => 'bar'], [])->shouldReturn($data);
$this->render($field, ['foo' => 'bar'], [])->shouldReturn('Value');
}

function it_escapes_objects_casted_to_string(DataExtractorInterface $dataExtractor, Field $field): void
{
$data = new class {
public function __toString(): string {
return '<i class="book icon"></i>';
}
};

$dataExtractor->get($field, ['foo' => 'bar'])->willReturn($data);
$this->render($field, ['foo' => 'bar'], [])->shouldReturn('&lt;i class=&quot;book icon&quot;&gt;&lt;/i&gt;');
}

function it_casts_ints_to_string(DataExtractorInterface $dataExtractor, Field $field): void
{
$dataExtractor->get($field, ['foo' => 'bar'])->willReturn(420);
$this->render($field, ['foo' => 'bar'], [])->shouldReturn('420');
}

function it_casts_floats_to_string(DataExtractorInterface $dataExtractor, Field $field): void
{
$dataExtractor->get($field, ['foo' => 'bar'])->willReturn(420.1337);
$this->render($field, ['foo' => 'bar'], [])->shouldReturn('420.1337');
}

function it_casts_null_to_string(DataExtractorInterface $dataExtractor, Field $field): void
{
$dataExtractor->get($field, ['foo' => 'bar'])->willReturn(null);
$this->render($field, ['foo' => 'bar'], [])->shouldReturn('');
}
}