Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for symfony 5 and remove support for < 4.4 #34

Merged
merged 1 commit into from
Jan 2, 2020

Conversation

dannyvw
Copy link

@dannyvw dannyvw commented Jan 2, 2020

Should be rebased after merging the other PR's

Copy link
Contributor

@pamil pamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase and customise component's composer.json (there's one Symfony dependency in require-dev)?

@dannyvw
Copy link
Author

dannyvw commented Jan 2, 2020

@pamil Done, but there are some fixes in #30 which are needed for this PR.

pamil added a commit that referenced this pull request Jan 2, 2020
This PR was merged into the 1.6-dev branch.

Discussion
----------

Support for Symfony version 3.4 is not fixed because it will be removed in #34

Commits
-------

e7d9998 Add support for php 7.4 and symfony 4.4
a7274f0 Replace deprecated doctrine object manager
8d7ad73 Fix order imports
90888e1 Update phpspec for component
ca74334 Add event-dispatcher to component
pamil added a commit to Sylius/Grid that referenced this pull request Jan 2, 2020
This PR was merged into the 1.6-dev branch.

Discussion
----------

Support for Symfony version 3.4 is not fixed because it will be removed in Sylius/SyliusGridBundle#34

Commits
-------

e7d9998792fe788d43350ab2a2510f9b50251c79 Add support for php 7.4 and symfony 4.4
a7274f056fe010a146fa17b4361f8b3a960670fa Replace deprecated doctrine object manager
8d7ad73b9510dbae7e24ad8f72271b2b898b0c05 Fix order imports
90888e16974803fb36c5cae37c2688cf418fa2a1 Update phpspec for component
ca74334af2c99a3d3248eaead7b03ed103d058c1 Add event-dispatcher to component
@pamil pamil added the Maintenance Configurations, READMEs, releases, etc. label Jan 2, 2020
@pamil pamil merged commit 8bf3d2d into Sylius:master Jan 2, 2020
@pamil
Copy link
Contributor

pamil commented Jan 2, 2020

Thank you, Danny! 🥇

@dannyvw dannyvw deleted the symfony5 branch January 2, 2020 19:23
@stloyd stloyd mentioned this pull request Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants