Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagerfanta updates #143

Closed
wants to merge 3 commits into from
Closed

Pagerfanta updates #143

wants to merge 3 commits into from

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Mar 19, 2021

Very simple PR which:

  • Updates the used adapter classes to stop using the deprecated classes
  • Allows Pagerfanta 3.0

@mbabker mbabker mentioned this pull request Nov 3, 2021
Merged
@lchrusciel lchrusciel closed this Nov 3, 2021
@lchrusciel lchrusciel reopened this Nov 3, 2021
@lchrusciel
Copy link
Member

Hey Michael,

sorry for lack of activity. Can you extend our workflow to check both versions? Perhaps with --prefer-lowest? Or just bump this dependency to 3.0, as it won't be supported since next year anywya

@mbabker
Copy link
Contributor Author

mbabker commented Nov 3, 2021

Or just bump this dependency to 3.0

Done. Now blocked by Sylius/SyliusResourceBundle#298 needing to allow 3.0 first 😅

@lchrusciel
Copy link
Member

Merged, now we need to release ResourceBundle. Perhaps next week

@mbabker mbabker mentioned this pull request Nov 12, 2021
Closed
loic425 added a commit to loic425/SyliusGridBundle that referenced this pull request Jan 10, 2022
@loic425
Add a conflict for pagerfanta 3.0 before allowing it in Sylius#143
37ea0d6
@loic425 loic425 mentioned this pull request Jan 10, 2022
Closed
@loic425 loic425 closed this Jan 25, 2022
@loic425 loic425 reopened this Jan 25, 2022
@loic425 loic425 mentioned this pull request Jan 25, 2022
Merged
lchrusciel added a commit that referenced this pull request Jan 28, 2022
@lchrusciel
refactor #205 Add support for pagerfanta 3 (loic425)
b45e6b9 
This PR was merged into the 1.10-dev branch.

Discussion
----------

replaces #143 

Commits
-------

c54718a Add support for pagerfanta 3
cda4dc8 Apply suggestions from code review
@lchrusciel
Copy link
Member

Hey Michael,

thanks a lot for your contribution and patience. What you've proposed landed in Grid in #205, therefore I'm closing this PR.

@lchrusciel lchrusciel closed this Jan 29, 2022
@mbabker mbabker deleted the feature/pagerfanta-upgrade branch February 4, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbabker @lchrusciel @loic425