Fix sorting grids by nullable path #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ws that does not have that path
Tomanhez
approved these changes
Jan 13, 2020
lchrusciel
reviewed
Jan 13, 2020
pamil
force-pushed
the
1.7-sortable-by-nullable-relation
branch
from
453ec4c to
f720e11
Compare
GSadee
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Actual behaviour
When I sort by nationality, it shows only the three authors that have a nationality assigned
Expected behaviour
When I sort by nationality, I would expect it to include all five authors, treating the ones without the nationality as it would be empty