bug #44 Fix sorting grids by nullable path (pamil)

This PR was merged into the 1.7 branch.

Discussion
----------

#### Background

- Author can have a nationality assigned, but does not have to
- Nationality have a name
- There are three authors with nationality assigned and two without

#### Actual behaviour

When I sort by nationality, it shows only the three authors that have a nationality assigned

#### Expected behaviour

When I sort by nationality, I would expect it to include all five authors, treating the ones without the nationality as it would be empty

Commits
-------

ca1b3e8 Reproduce: when sorted by nullable path, the grid does not include rows that does not have that path
f720e11 Fix sorting grids by nullable path

src/Bundle/Doctrine/ORM/ExpressionBuilder.php

@@ -216,7 +216,7 @@ private function resolveFieldByAddingJoins(string $field): string
                 }
             }
 
-            $this->queryBuilder->innerJoin($rootAndAssociationField, $associationAlias);
+            $this->queryBuilder->leftJoin($rootAndAssociationField, $associationAlias);
             $resolvedField = sprintf('%s.%s', $associationAlias, $remainder);
         }
 

src/Bundle/Tests/DataFixtures/ORM/fixtures.yml

@@ -11,6 +11,8 @@ AppBundle\Entity\Author:
     author_john_watson:
         name: "John Watson"
         nationality: "@nationality_english"
+    author_random:
+        name: "Random Author Without Nationality"
     author_{1..19}:
         name: "<firstName()> <lastName()>"
         nationality: "@nationality_english"

src/Bundle/Tests/Functional/GridApiTest.php

@@ -229,6 +229,23 @@ public function it_filters_books_by_author_when_an_author_is_used_in_join_in_que
         $this->assertSame('A Study in Scarlet', $this->getFirstItemFromCurrentResponse()['title']);
     }
 
+    /** @test */
+    public function it_includes_all_rows_even_when_sorting_by_a_nullable_path(): void
+    {
+        $this->client->request('GET', '/authors/');
+        $totalItemsCountBeforeSorting = $this->getTotalItemsCountFromCurrentResponse();
+
+        $this->client->request('GET', '/authors/?sorting[nationality]=desc');
+        $totalItemsCountAfterSorting = $this->getTotalItemsCountFromCurrentResponse();
+
+        $this->assertSame($totalItemsCountBeforeSorting, $totalItemsCountAfterSorting);
+    }
+
+    private function getTotalItemsCountFromCurrentResponse(): int
+    {
+        return json_decode($this->client->getResponse()->getContent(), true)['total'];
+    }
+
     private function getItemsFromCurrentResponse(): array
     {
         return json_decode($this->client->getResponse()->getContent(), true)['_embedded']['items'];

src/Bundle/Tests/Responses/Expected/authors_grid.json

@@ -2,7 +2,7 @@
     "page": 1,
     "limit": 10,
     "pages": 3,
-    "total": 21,
+    "total": 22,
     "_links": {
         "self": {
             "href": "\/authors\/?page=1&limit=10"

src/Bundle/test/app/config/grids.yml

@@ -67,6 +67,11 @@ sylius_grid:
                     type: string
                     label: Name
                     sortable: ~
+                nationality:
+                    type: string
+                    label: Name
+                    sortable: nationality.name
+                    path: nationality.name
             limits: [10, 5, 15]
 
         app_book_by_american_authors:

src/Bundle/test/src/AppBundle/Resources/config/doctrine/Author.orm.yml

@@ -22,4 +22,5 @@ AppBundle\Entity\Author:
             joinColumn:
                 name: nationality_id
                 referencedColumnName: id
+                nullable: true
             cascade: ["all"]