Fix doubled province id on checkout addressing page #9772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamil
added
Potential Bug
Zales0123
approved these changes
Oct 3, 2018
|
I'm not sure how (and if we want) to test that. It's doubled ID, so it could happen anywhere and the test would look like "check if the HTML is valid". |
|
Ok, doubled ID, not name or anything relevant for the data xD Sorry for the moment of unconsciousness 🐰 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9134. Not the most elegant solution, but it seems like that whole province-related logic needs some love. Happy resolving merge conflicts to the future me!