Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup swagger.yml from remains ChannelCode parameters #570

Merged
merged 1 commit into from
Oct 20, 2019
Merged

Cleanup swagger.yml from remains ChannelCode parameters #570

merged 1 commit into from
Oct 20, 2019

Conversation

diimpp
Copy link
Member

@diimpp diimpp commented Oct 2, 2019

No description provided.

@diimpp diimpp requested a review from a team as a code owner October 2, 2019 13:21
@mamazu
Copy link
Member

mamazu commented Oct 2, 2019

I think we should remove the whole #/parameters/ChannelCode definition.

@diimpp
Copy link
Member Author

diimpp commented Oct 2, 2019

Done

@diimpp
Copy link
Member Author

diimpp commented Oct 9, 2019

@mamazu ping :)

@lchrusciel
Copy link
Member

Hello Dimitri,

thank a lot for PR. Just to let you know, I have checkouted it and forced pushed version rebased to the master.

@lchrusciel lchrusciel merged commit a6307ee into Sylius:master Oct 20, 2019
@lchrusciel
Copy link
Member

Thank you, Dmitri! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamazu mamazu mamazu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diimpp @mamazu @lchrusciel