Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Customer] Fix customer update action #568

Merged
merged 1 commit into from
Sep 26, 2019
Merged

[Customer] Fix customer update action #568

merged 1 commit into from
Sep 26, 2019

Conversation

lchrusciel
Copy link
Member

No description provided.

@lchrusciel lchrusciel requested a review from a team as a code owner September 25, 2019 14:20
@lchrusciel
Copy link
Member Author

Huge thank you to @matik955, who reported this issue directly to us, as it could be a security vulnerability.
giphy

@lchrusciel lchrusciel merged commit dbb7caa into Sylius:master Sep 26, 2019
@lchrusciel lchrusciel deleted the improved-user-update branch October 1, 2019 13:27
@mamazu
Copy link
Member

mamazu commented Oct 4, 2019 •
edited
Loading

For those of you wondering what the bug was. That the customer could update the email address and impersonate other users with it.

@mamazu mamazu mentioned this pull request Dec 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamazu mamazu mamazu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lchrusciel @mamazu