Adding translations and unifying keys

spec/Validator/Product/ConfigurableProductValidatorSpec.php

@@ -59,7 +59,7 @@ function it_adds_a_violation_if_the_product_exists_and_is_not_configurable(
 
         $product->isConfigurable()->willReturn(false);
 
-        $executionContext->addViolation('sylius.shop_api.product.configurable')->shouldBeCalled();
+        $executionContext->addViolation('sylius.shop_api.product.not_configurable')->shouldBeCalled();
 
         $this->validate('PRODUCT_CODE', new ConfigurableProduct());
     }

spec/Validator/Product/ProductExistsValidatorSpec.php

@@ -45,7 +45,7 @@ function it_adds_constraint_if_product_does_not_exists(
     ): void {
         $productRepository->findOneByCode('BARBECUE_CODE')->willReturn(null);
 
-        $executionContext->addViolation('sylius.shop_api.product.exists')->shouldBeCalled();
+        $executionContext->addViolation('sylius.shop_api.product.not_exists')->shouldBeCalled();
 
         $this->validate('BARBECUE_CODE', new ProductExists());
     }

spec/Validator/Product/SimpleProductValidatorSpec.php

@@ -58,7 +58,7 @@ function it_adds_constraint_if_is_not_simple(
         $productRepository->findOneByCode('BARBECUE_CODE')->willReturn($product);
         $product->isSimple()->willReturn(false);
 
-        $executionContext->addViolation('sylius.shop_api.product.simple')->shouldBeCalled();
+        $executionContext->addViolation('sylius.shop_api.product.not_simple')->shouldBeCalled();
 
         $this->validate('BARBECUE_CODE', new SimpleProduct());
     }

src/Resources/translations/validators.en.yml

@@ -1,20 +1,33 @@
 sylius:
     shop_api:
+        channel:
+            not_exists: Channel does not exist.
         cart:
-            not_exists: Cart does not exists.
+            not_exists: Cart does not exist.
+        cart_item:
+            not_exists: Cart item does not exist.
+        token:
+            already_taken: There is already a cart with this token.
         email:
             not_blank: Please enter your email.
             invalid: This email is invalid.
             unique: This email is already used.
+            not_found: There is no user with this email address
         password:
             not_blank: Please enter your password.
         first_name:
             not_blank: Please enter your first name.
         last_name:
             not_blank: Please enter your last name.
         address_id:
-            not_null: Please provide address id
+            not_null: Please provide address id.
         address:
-            not_exists: Address doesn't exist
+            not_exists: Address does not exist.
         country:
-            not_exists: The country does not exist
+            not_exists: The country does not exist.
+        product:
+            not_configurable: The product is not configurable.
+            not_found: The product does not exists.
+            not_simple: The product is not a simple product
+        product_variant:
+            not_exists: The product variant does not exist.

src/Validator/Constraints/ConfigurableProduct.php

@@ -9,7 +9,7 @@
 final class ConfigurableProduct extends Constraint
 {
     /** @var string */
-    public $message = 'sylius.shop_api.product.configurable';
+    public $message = 'sylius.shop_api.product.not_configurable';
 
     /** {@inheritdoc} */
     public function getTargets()

src/Validator/Constraints/ProductExists.php

@@ -9,7 +9,7 @@
 final class ProductExists extends Constraint
 {
     /** @var string */
-    public $message = 'sylius.shop_api.product.exists';
+    public $message = 'sylius.shop_api.product.not_exists';
 
     /** {@inheritdoc} */
     public function getTargets()

src/Validator/Constraints/SimpleProduct.php

@@ -9,7 +9,7 @@
 final class SimpleProduct extends Constraint
 {
     /** @var string */
-    public $message = 'sylius.shop_api.product.simple';
+    public $message = 'sylius.shop_api.product.not_simple';
 
     /** {@inheritdoc} */
     public function getTargets()

tests/Responses/Expected/cart/cart_and_country_does_not_exist_response.json

@@ -3,10 +3,10 @@
     "message": "Validation failed",
     "errors": {
         "cartToken": [
-            "Cart does not exists."
+            "Cart does not exist."
         ],
         "countryCode": [
-            "The country does not exist"
+            "The country does not exist."
         ]
     }
 }

tests/Responses/Expected/cart/cart_item_has_not_been_found_response.json

@@ -3,7 +3,7 @@
     "message": "Validation failed",
     "errors": {
         "id": [
-            "sylius.shop_api.cart_item.not_exists"
+            "Cart item does not exist."
         ]
     }
 }

tests/Responses/Expected/cart/validation_cart_and_cart_item_not_exist_response.json

@@ -3,10 +3,10 @@
     "message": "Validation failed",
     "errors": {
         "token": [
-            "Cart does not exists."
+            "Cart does not exist."
         ],
         "id": [
-            "sylius.shop_api.cart_item.not_exists"
+            "Cart item does not exist."
         ]
     }
 }

tests/Responses/Expected/cart/validation_cart_item_not_exists_response.json

@@ -3,7 +3,7 @@
     "message": "Validation failed",
     "errors": {
         "id": [
-            "sylius.shop_api.cart_item.not_exists"
+            "Cart item does not exist."
         ]
     }
 }

tests/Responses/Expected/cart/validation_cart_not_exists_response.json

@@ -3,7 +3,7 @@
     "message": "Validation failed",
     "errors": {
         "token": [
-            "Cart does not exists."
+            "Cart does not exist."
         ]
     }
 }

tests/Responses/Expected/cart/validation_product_not_configurable_response.json

@@ -3,7 +3,7 @@
     "message": "Validation failed",
     "errors": {
         "productCode": [
-            "sylius.shop_api.product.configurable"
+            "The product is not configurable."
         ]
     }
 }

tests/Responses/Expected/cart/validation_product_not_defined_response.json

@@ -4,7 +4,7 @@
     "errors": {
         "productCode": [
             "sylius.shop_api.product.not_null",
-            "sylius.shop_api.product.exists"
+            "sylius.shop_api.product.not_exists"
         ]
     }
 }

tests/Responses/Expected/cart/validation_product_not_exists_response.json

@@ -3,7 +3,7 @@
     "message": "Validation failed",
     "errors": {
         "productCode": [
-            "sylius.shop_api.product.exists"
+            "sylius.shop_api.product.not_exists"
         ]
     }
 }

tests/Responses/Expected/cart/validation_product_not_simple_response.json

@@ -3,7 +3,7 @@
     "message": "Validation failed",
     "errors": {
         "productCode": [
-            "sylius.shop_api.product.simple"
+            "The product is not a simple product"
         ]
     }
 }

tests/Responses/Expected/customer/validation_email_not_defined_response.json

@@ -4,7 +4,7 @@
     "errors": {
         "email": [
             "sylius.shop_api.email.not_null",
-            "sylius.shop_api.email.not_found"
+            "There is no user with this email address"
         ]
     }
 }

tests/Responses/Expected/customer/validation_email_not_found_response.json

@@ -3,7 +3,7 @@
     "message": "Validation failed",
     "errors": {
         "email": [
-            "sylius.shop_api.email.not_found"
+            "There is no user with this email address"
         ]
     }
 }

tests/Responses/Expected/customer/validation_email_not_valid_response.json

@@ -4,7 +4,7 @@
     "errors": {
         "email": [
             "sylius.shop_api.email.not_valid",
-            "sylius.shop_api.email.not_found"
+            "There is no user with this email address"
         ]
     }
 }