Fix CartBlamerListener case with empty token #528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
reviewed
Sep 9, 2019
| @@ -44,7 +44,9 @@ public function onJwtLogin(JWTCreatedEvent $interactiveLoginEvent): void | |||
| return; | |||
| } | |||
|
|
|||
| $token = $request->request->get('token'); | |||
| if (null === $token = $request->request->get('token')) { | |||
There was a problem hiding this comment.
Can we leave token in a separate line?
Also, we miss test for this behavior. Can you add it to PickupApiTest file? Or introduce spec for this class? Or (in the best case) do both? :)
|
One thing I would even recommend is using a CartProvider with token. This would also allow users to add more constraints and checks on it (eg. is cart in current channel and so on). |
|
Thanks Dmitri for the contribution! Nevertheless, this issue will be solved by #536, as it contains a documentation as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves false-positive CartBlamerListener execution.
If database contains orders without
tokenValue, then it will return non-null$cartresult for null$token. Order.orm.xml tokenValue is nullable