[Product] Remove channel code from product routes #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSadee
force-pushed
the
remove-channel-code-from-product
branch
from
2941944
to
98a3f8f
Compare
lchrusciel
approved these changes
Jul 19, 2019
| new PaginatorDetails($request->attributes->get('_route'), $request->query->all()), | ||
| $request->query->get('locale') | ||
| ), Response::HTTP_OK)); | ||
| } catch (ChannelNotFoundException $exception) { | ||
| throw new NotFoundHttpException('Channel has not been found.'); | ||
| } catch (\InvalidArgumentException $exception) { |
There was a problem hiding this comment.
Do we still need to mute all \InvalidArgumentException?
There was a problem hiding this comment.
Ok, it is due to old Assert implementation :(
|
Thanks, Grzegorz! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.