-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secure checkout complete action #365
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
force-pushed
the
checkout_bug
branch
from
January 3, 2019 14:45
420904d
to
89de93e
Compare
/cc @mamazu Will it work for you? |
Closed
lchrusciel
force-pushed
the
checkout_bug
branch
from
January 3, 2019 15:07
89de93e
to
21dd0dd
Compare
Thanks for picking up the work. |
mamazu
reviewed
Jan 3, 2019
lchrusciel
force-pushed
the
checkout_bug
branch
from
January 4, 2019 08:17
21dd0dd
to
ab7e3e9
Compare
Zales0123
approved these changes
Jan 4, 2019
lchrusciel
force-pushed
the
checkout_bug
branch
from
January 4, 2019 13:36
ab7e3e9
to
a8e8762
Compare
Zales0123
approved these changes
Jan 4, 2019
Thanks, Łukasz! 🥇 |
And Maximilian! |
And Maximilian! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the improved implementation of #351. Current implementation will support following scenarios: