Removed unused cart controller #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamazu
force-pushed
the
unused_controller
branch
from
40c690f
to
1329e48
Compare
|
Looks like it is used - https://travis-ci.org/Sylius/SyliusShopApiPlugin/jobs/418205962#L818. |
|
Ok, it looks odd. Maybe we should refactor it. |
|
Remove item should be removed for 100%. Delivery cost estimation should be saved, but I'm not sure if we need it for 1.0. In the best scenario, we can move shipping price estimation to a better place and adopt new controller implementation. |
|
That's what I thought too. |
mamazu
force-pushed
the
unused_controller
branch
from
1329e48
to
5c310c5
Compare
pamil
approved these changes
Aug 20, 2018
|
Thank you, Maximilian! 🎉 |
|
Your welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an old controller that is not used anymore. So we can safely remove it.