Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue in the configuration example which causes error in loading checkout page. #246

Conversation

Hailong
Copy link
Contributor

@Hailong Hailong commented Jan 10, 2018

The CheckoutResolver should only be applied to the subpath of checkout, it would causes error in loading the root checkout path if enabled.

@lchrusciel lchrusciel merged commit e835848 into Sylius:master Jan 11, 2018
@lchrusciel
Copy link
Member

Thanks Hailong! And welcome to our community! :)

Are you willing to provide some tests to avoid regression?

@Hailong
Copy link
Contributor Author

Hailong commented Jan 11, 2018

Thank you @lchrusciel , Sylius is a great framework!! I'm actually implementing an eCommerce application based on Sylius and the Shop API, so I guess it will cover all the basic scenarios.

I have also enabled the LexikJWTAuthenticationBundle for Shop API, and added a custom authentication provider to enable a third-party authentication. Now I'm exploring the cart and order workflows...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants