improved product api routing configuration

Sylius · Jun 8, 2019 · 3cadb9c · 3cadb9c
1 parent 87de8f5
commit 3cadb9c
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 33 deletions.
diff --git a/src/Resources/config/routing/productByCode.yml b/src/Resources/config/routing/productByCode.yml
@@ -1,15 +1,3 @@
-sylius_shop_api_product_show_details_by_code:
-    path: /products/by-code/{code}
-    methods: [GET]
-    defaults:
-        _controller: sylius.shop_api_plugin.controller.product.show_product_details_by_code_action
-
-sylius_shop_api_product_show_catalog_by_code:
-    path: /taxon-products/by-code/{taxonCode}
-    methods: [GET]
-    defaults:
-        _controller: sylius.shop_api_plugin.controller.product.show_product_catalog_by_taxon_code_action
-
 sylius_shop_api_product_show_reviews_by_code:
     path: /products/by-code/{code}/reviews
     methods: [GET]
@@ -21,3 +9,15 @@ sylius_shop_api_add_product_review_by_code:
     methods: [POST]
     defaults:
         _controller: sylius.shop_api_plugin.controller.product.add_review_by_code_action
+
+sylius_shop_api_product_show_details_by_code:
+    path: /products/by-code/{code}
+    methods: [GET]
+    defaults:
+        _controller: sylius.shop_api_plugin.controller.product.show_product_details_by_code_action
+
+sylius_shop_api_product_show_catalog_by_code:
+    path: /taxon-products/by-code/{taxonCode}
+    methods: [GET]
+    defaults:
+        _controller: sylius.shop_api_plugin.controller.product.show_product_catalog_by_taxon_code_action
diff --git a/src/Resources/config/routing/productBySlug.yml b/src/Resources/config/routing/productBySlug.yml
@@ -1,19 +1,3 @@
-sylius_shop_api_product_show_details_by_slug:
-    path: /products/by-slug/{slug}
-    methods: [GET]
-    defaults:
-        _controller: sylius.shop_api_plugin.controller.product.show_product_details_by_slug_action
-    requirements:
-        slug: .+
-
-sylius_shop_api_product_show_catalog_by_slug:
-    path: /taxon-products/by-slug/{taxonSlug}
-    methods: [GET]
-    defaults:
-        _controller: sylius.shop_api_plugin.controller.product.show_product_catalog_by_taxon_slug_action
-    requirements:
-        taxonSlug: .+
-
 sylius_shop_api_product_show_reviews_by_slug:
     path: /products/by-slug/{slug}/reviews
     methods: [GET]
@@ -29,3 +13,19 @@ sylius_shop_api_add_product_review_by_slug:
         _controller: sylius.shop_api_plugin.controller.product.add_review_by_slug_action
     requirements:
         slug: .+
+
+sylius_shop_api_product_show_details_by_slug:
+    path: /products/by-slug/{slug}
+    methods: [GET]
+    defaults:
+        _controller: sylius.shop_api_plugin.controller.product.show_product_details_by_slug_action
+    requirements:
+        slug: .+
+
+sylius_shop_api_product_show_catalog_by_slug:
+    path: /taxon-products/by-slug/{taxonSlug}
+    methods: [GET]
+    defaults:
+        _controller: sylius.shop_api_plugin.controller.product.show_product_catalog_by_taxon_slug_action
+    requirements:
+        taxonSlug: .+
diff --git a/tests/Application/config/packages/doctrine.yaml b/tests/Application/config/packages/doctrine.yaml
@@ -11,4 +11,4 @@ doctrine:
         server_version: '5.7'
         charset: UTF8
 
-        url: '%env(resolve:DATABASE_URL)%'
+        url: 'mysql://root:rootroot@127.0.0.1/sylius_shop_api_%kernel.environment%?serverVersion=5.5'
diff --git a/tests/Responses/Expected/product/product_review_list_page_by_slug_response.json b/tests/Responses/Expected/product/product_review_list_page_by_slug_response.json
@@ -4,10 +4,10 @@
     "pages": 3,
     "total": 25,
     "_links": {
-        "self": "\/shop-api\/WEB_GB\/product\/by-slug\/logan-mug\/reviews?page=1&limit=10",
-        "first": "\/shop-api\/WEB_GB\/product\/by-slug\/logan-mug\/reviews?page=1&limit=10",
-        "last": "\/shop-api\/WEB_GB\/product\/by-slug\/logan-mug\/reviews?page=3&limit=10",
-        "next": "\/shop-api\/WEB_GB\/product\/by-slug\/logan-mug\/reviews?page=2&limit=10"
+        "self": "\/shop-api\/WEB_GB\/products\/by-slug\/logan-mug\/reviews?page=1&limit=10",
+        "first": "\/shop-api\/WEB_GB\/products\/by-slug\/logan-mug\/reviews?page=1&limit=10",
+        "last": "\/shop-api\/WEB_GB\/products\/by-slug\/logan-mug\/reviews?page=3&limit=10",
+        "next": "\/shop-api\/WEB_GB\/products\/by-slug\/logan-mug\/reviews?page=2&limit=10"
     },
     "items": [
         {