Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing factory for line items #423

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Add missing factory for line items #423

merged 4 commits into from
Feb 13, 2024

Conversation

NoResponseMate
Copy link
Contributor

Q A
Branch? 1.5
Bug fix? kinda
New feature? kinda
Related tickets related #416

@NoResponseMate NoResponseMate requested a review from a team as a code owner February 12, 2024 16:46
@GSadee GSadee added Feature New feature proposals. DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). and removed Feature New feature proposals. labels Feb 13, 2024
@GSadee GSadee merged commit 0054251 into Sylius:1.5 Feb 13, 2024
13 checks passed
@GSadee
Copy link
Member

GSadee commented Feb 13, 2024

Thank you, Jan! 🥇

@NoResponseMate NoResponseMate deleted the fix/use-line-item-factory branch February 13, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wojdylak Wojdylak Wojdylak approved these changes

@oallain oallain oallain approved these changes

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NoResponseMate @GSadee @oallain @Wojdylak