-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maintenance] Optional pdf generator #367
Conversation
And you need to check |
5e58132
to
6fc3c0d
Compare
6fc3c0d
to
699782d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to add a test for checking if everything will be ok when the flag is disabled and there is no wkhtmltopdf binary defined
f2f9f6c
to
43f4779
Compare
…hod instead of load() method
…ditMemo download button to use events
…emo PDF file when PDF generator is turned off
…itMemo download button to use events
…mo PDF file when PDF generator is turned off
… pdf generator is turned off
43f4779
to
0d77a21
Compare
817be96
to
047117b
Compare
047117b
to
546905b
Compare
Thanks, Rafał & Grzegorz! 🎉 |
…bled to the main workflow (GSadee) This PR was merged into the 1.2 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.2 | Bug fix? | no | New feature? | no | Related tickets | after #367 Commits ------- 86dcb02 [GitHub Actions] Include build with PDF generation disabled to the ma… 752056f [GitHub Actions] Merge steps for disabling PDF generation into one
To not force users to install the
wkhtmltopdf
binary we introduced a configuration that allows disabling PDF generation.Turned on:
Turned off:
Turned on:
Turned off:
Turned on:
Turned off:
And same on the customer account page