Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Templates][Admin] Replace templates overriding with events #365

Merged
merged 4 commits into from
Apr 26, 2022
Merged

[Templates][Admin] Replace templates overriding with events #365

merged 4 commits into from
Apr 26, 2022

Conversation

coldic3
Copy link
Contributor

@coldic3 coldic3 commented Apr 20, 2022 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? no
Related tickets

Requires Sylius/Sylius#13886.

TODO:

  • Update sylius/sylius min version in composer.json after new Sylius/Sylius release.

@coldic3 coldic3 force-pushed the feature/order-payments-template-events branch 2 times, most recently from 4ebcacd to bfb77e8 Compare April 20, 2022 11:04
@coldic3 coldic3 force-pushed the feature/order-payments-template-events branch from bfb77e8 to 0f045e0 Compare April 20, 2022 11:05
@coldic3 coldic3 marked this pull request as ready for review April 20, 2022 11:06
@coldic3 coldic3 requested a review from a team as a code owner April 20, 2022 11:06
@coldic3 coldic3 changed the title [Templates][Events][Admin] Replace templates overriding with events [Templates][Admin] Replace templates overriding with events Apr 20, 2022
@coldic3 coldic3 added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). DX Issues and PRs aimed at improving Developer eXperience. labels Apr 20, 2022
GSadee
GSadee reviewed Apr 25, 2022
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a proper note to an UPGRADE file about the need to remove these templates from the end application

@coldic3
Copy link
Contributor Author

coldic3 commented Apr 25, 2022

@GSadee done

@coldic3 coldic3 force-pushed the feature/order-payments-template-events branch from 2d169ab to dddbf21 Compare April 25, 2022 06:54
@GSadee GSadee merged commit 9bb2cde into Sylius:master Apr 26, 2022
@GSadee
Copy link
Member

GSadee commented Apr 26, 2022

Thanks, Kevin! 🥇

@coldic3 coldic3 deleted the feature/order-payments-template-events branch April 26, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@Rafikooo Rafikooo Rafikooo approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coldic3 @GSadee @Rafikooo