Merge pull request #447 from GSadee/SYL-4156-refactor-parameters-name…

…s-in-1.x Rename and deprecate parameters
Sylius · Nov 25, 2024 · 8835a11 · 8835a11
2 parents 01cc445 + e5fabb9
commit 8835a11
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 3 deletions.
diff --git a/UPGRADE-1.6.md b/UPGRADE-1.6.md
@@ -97,3 +97,10 @@
    | `Sylius\RefundPlugin\StateResolver\RefundPaymentCompletedStateApplierInterface`  | `sylius_refund.state_resolver.refund_payment_completed_applier` |
    | `Sylius\RefundPlugin\Validator\RefundAmountValidatorInterface`                   | `sylius_refund.validator.refund_amount`                         |
    | `Sylius\RefundPlugin\Validator\RefundUnitsCommandValidatorInterface`             | `sylius_refund.validator.refund_units_command`                  |
+
+1. The following old parameters have been deprecated and will be removed in RefundPlugin 2.0. Use the corresponding new parameters instead:
+
+   | Old parameter                      | New parameter                      | 
+   |------------------------------------|------------------------------------|
+   | `default_logo_file`                | `sylius_refund.default_logo_file`  |
+   | `sylius.refund.template.logo_file` | `sylius_refund.template.logo_file` |
diff --git a/src/Resources/config/app/config.yml b/src/Resources/config/app/config.yml
@@ -11,7 +11,7 @@ parameters:
 sylius_refund:
     pdf_generator:
         allowed_files:
-            - '%env(default:default_logo_file:resolve:SYLIUS_REFUND_LOGO_FILE)%'
+            - '%env(default:sylius_refund.default_logo_file:resolve:SYLIUS_REFUND_LOGO_FILE)%'
 
 sylius_resource:
     resources:

diff --git a/src/Resources/config/services.xml b/src/Resources/config/services.xml
@@ -22,7 +22,10 @@
 
     <parameters>
         <parameter key="default_logo_file">@SyliusRefundPlugin/Resources/assets/sylius-logo.png</parameter>
-        <parameter key="sylius.refund.template.logo_file">%env(default:default_logo_file:resolve:SYLIUS_REFUND_LOGO_FILE)%</parameter>
+        <parameter key="sylius.refund.template.logo_file">%env(default:sylius_refund.default_logo_file:resolve:SYLIUS_REFUND_LOGO_FILE)%</parameter>
+
+        <parameter key="sylius_refund.default_logo_file">%default_logo_file%</parameter>
+        <parameter key="sylius_refund.template.logo_file">%sylius.refund.template.logo_file%</parameter>
     </parameters>
 
     <services>

diff --git a/src/Resources/config/services/generators.xml b/src/Resources/config/services/generators.xml
@@ -53,7 +53,7 @@
             <argument>null</argument>
             <argument type="service" id="file_locator" />
             <argument>@SyliusRefundPlugin/Download/creditMemo.html.twig</argument>
-            <argument>%sylius.refund.template.logo_file%</argument>
+            <argument>%sylius_refund.template.logo_file%</argument>
             <argument>null</argument>
             <argument type="service" id="sylius_refund.generator.twig_to_pdf" />
             <argument type="service" id="sylius_refund.generator.credit_memo_file_name" />