Merge branch '1.4' into 1.5

* 1.4: Remove outdated phpstan ignores [RefundUnitsConverter] Change interface method signature
Sylius · Jun 30, 2023 · 66c42d3 · 66c42d3
2 parents a7b978e + 645dad8
commit 66c42d3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Converter/RefundUnitsConverterInterface.php b/src/Converter/RefundUnitsConverterInterface.php
@@ -13,8 +13,10 @@
 
 namespace Sylius\RefundPlugin\Converter;
 
+use Sylius\RefundPlugin\Model\RefundTypeInterface;
+
 /**
- * @method array convert(array $units, string $unitRefundClass)
+ * @method array convert(array $units, string|RefundTypeInterface $unitRefundClass)
  */
 interface RefundUnitsConverterInterface
 {

diff --git a/src/Creator/RefundUnitsCommandCreator.php b/src/Creator/RefundUnitsCommandCreator.php
@@ -40,15 +40,13 @@ public function fromRequest(Request $request): RefundUnits
             /** @phpstan-ignore-next-line */
             $units = $this->requestToRefundUnitsConverter->convert(
                 $request->request->has('sylius_refund_units') ? $request->request->all()['sylius_refund_units'] : [],
-                /** @phpstan-ignore-next-line */
                 RefundType::orderItemUnit(),
                 OrderItemUnitRefund::class,
             );
 
             /** @phpstan-ignore-next-line */
             $shipments = $this->requestToRefundUnitsConverter->convert(
                 $request->request->has('sylius_refund_shipments') ? $request->request->all()['sylius_refund_shipments'] : [],
-                /** @phpstan-ignore-next-line */
                 RefundType::shipment(),
                 ShipmentRefund::class,
             );