Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

avoid attribute errors when accessing connection #368

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

zvictor
Copy link
Contributor

@zvictor zvictor commented Feb 26, 2020

Thank you for publishing ddp-apollo! Even though I am not using it directly, I managed to solve a humongous old bug in my application while studying how you managed to invoke dpp calls (#190).

Things were going pretty well until I started getting errors while trying to call Meteor's verifyEmail.
The problem was that connection: null results in (null).id at accounts_server.js:855:

https://github.com/meteor/meteor/blob/573c9dc478b15df70fa26c4a753d62077df1b066/packages/accounts-base/accounts_server.js#L854-L856

Setting connection: {} solves the issue to me, so I would like to know if there is any reason to keep null instead.

@Cliffzz
Copy link
Member

Cliffzz commented Jan 20, 2021

Thank you! Looks good to me, I'm not a 100% sure why it was done this way before.

@Cliffzz Cliffzz merged commit ce7c3b7 into Swydo:master Jan 20, 2021
@zvictor zvictor deleted the patch-1 branch January 22, 2021 09:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants