This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
avoid attribute errors when accessing connection
#368
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for publishing
ddp-apollo
! Even though I am not using it directly, I managed to solve a humongous old bug in my application while studying how you managed to invoke dpp calls (#190).Things were going pretty well until I started getting errors while trying to call Meteor's
verifyEmail
.The problem was that
connection: null
results in(null).id
at accounts_server.js:855:https://github.com/meteor/meteor/blob/573c9dc478b15df70fa26c4a753d62077df1b066/packages/accounts-base/accounts_server.js#L854-L856
Setting
connection: {}
solves the issue to me, so I would like to know if there is any reason to keepnull
instead.