Feat/cross chain eip712 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yan-soon
reviewed
Sep 25, 2024
ethereum/eip712/encoding.go
Outdated
| if len(signedChainSplit) != 2 || len(carbonChainSplit) != 2 { | ||
| return apitypes.TypedData{}, errors.New("invalid memo") | ||
| } | ||
| aminoDoc.ChainID = signedChainSplit[1] |
There was a problem hiding this comment.
i think we can shift the replay attack guard here, since the chainId is just a static variable initialised in Makefile.
import the evm keeper:
evmkeeper "github.com/evmos/ethermint/x/evm/keeper"
// Check the carbon chain ID to prevent replay attack
if carbonChainSplit[1] != evmkeeper.EvmChainId {
return apitypes.TypedData{}, fmt.Errorf("invalid chainId, expected %v, got %v", evmkeeper.EvmChainId, carbonChainSplit[1])
}
yan-soon
reviewed
Sep 25, 2024
yan-soon
approved these changes
Sep 26, 2024
yan-soon
pushed a commit
that referenced
this pull request
Sep 26, 2024
* fix verifyingContract to be a valid evm hex address (using `cosmos` as hex address) * Add logs to decodeAminoSignDoc * Only use 2 logs * Add chainID logs * Add draft memo processing to change typedData * Update signedChainId processing * Move memo processing above parsingchainId * Remove unused domainID and other variables * Remove logs * Add memo processing chain id in protobug doc * Add logs for protobuf signdoc * move memo processing in protobuf below signBytes * Fix proto signing doc * Refactor getChainIDFromMemo and add carbon chain check --------- Co-authored-by: Randy <randy75828@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross chain EIP712 to do processing of eip712 structure in ethermint
For https://github.com/Switcheo/carbon/pull/966