🐛 Fix: Optimistically render when drag-and-dropping event #209
Conversation
There was a problem hiding this comment.
This approach is looking good. I started a little cleanup to make the saga easier to understand. I'll continue the cleanup and merge after QAing a little more.
Can you plz start on #207 next?
Fixes [issue](SwitchbackTech#203) In this commit, whenever we drag and drop a someday event to the grid, we now handle: - Optimistically removing the someday event from the sidebar - Optimistically inserting the grid event We also error handle the optimistic flow and revert if needed
'order' and 'recurrence' aren't currently needed for a grid event
tyler-dane
force-pushed
the
fix_dnd_sidebar_event_to_grid
branch
from
c435313 to
56b83f8
Compare
splitting things out of the convertSomedayEvent saga will make the saga more readable
this is to make it easier to understand sagas work
…nto smaller generators
tyler-dane
force-pushed
the
fix_dnd_sidebar_event_to_grid
branch
from
a809445 to
543cc01
Compare
|
Nice work, @that-one-arab! You'll notice that my commits don't sneak in any extra functionality. I also didn't go overboard and try to clean up things in parts of the codebase that don't relate to this issue. Instead, I refactored the files that already changed to improve readability and testability. This is the "clean up as we go" strategy I'd like us to take whenever possible. This will help us improve code stability, make the codebase more approachable, and make it easier to refactor (eg when we replace Redux Saga)... all while avoiding massive PRs that slow progress. |
|
@tyler-dane Yep I agree. I'll try to make more of these refactors as I understand the codebase more and more. |
Fixes issue
In this commit, whenever we drag and drop a someday event to the grid, we now handle:
We also error handle the optimistic flow and revert if needed
Peek.2024-12-31.07-50.webm