🏗 build(cli): extract args before running build cmd #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler-dane
changed the title
tyler-dane
force-pushed
the
feat/195-cli
branch
2 times, most recently
from
60c043b to
2bda7f0
Compare
tyler-dane
changed the title
tyler-dane
changed the title
tyler-dane
force-pushed
the
feat/195-cli
branch
2 times, most recently
from
1259eb7 to
7b18fe2
Compare
this improves readability, because the class has access to the 'options', which means we don't have to keep passing that arg to the util functions
tyler-dane
force-pushed
the
feat/195-cli
branch
from
7b18fe2 to
90d8729
Compare
this makes the division of responsibilities more clear: the Validator parses cli args and validates their inputs against our types. The CLI is then free to accept the parsed args and simply trigger the provided commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #195