Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return stdout from commands #131

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Return stdout from commands #131

merged 1 commit into from
Apr 7, 2023

Conversation

PascalSenn
Copy link
Member

@PascalSenn PascalSenn commented Apr 7, 2023 •
edited
Loading

  • Exposed DockerClient in IDockerContainerManager interface and moved its initialization to a public property Client in DockerContainerManager, enabling better access to the Docker client outside of the class.
  • Updated InvokeCommandAsync to return stdout as a string, improving usability by returning command output directly.

@PascalSenn PascalSenn requested review from RohrerF and glucaci and removed request for RohrerF April 7, 2023 11:21
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@PascalSenn PascalSenn merged commit 0c94752 into master Apr 7, 2023
@PascalSenn PascalSenn deleted the pse/refactor-command-execution branch April 7, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glucaci glucaci glucaci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PascalSenn @glucaci