Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node 4 on travis #784

Merged
merged 2 commits into from
Sep 16, 2015
Merged

Add node 4 on travis #784

merged 2 commits into from
Sep 16, 2015

Conversation

Swiip
Copy link
Owner

@Swiip Swiip commented Sep 14, 2015

Just for fun :)

@@ -3,6 +3,7 @@ sudo: false
node_js:
- '0.10'
- '0.12'
- '4.0'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace by stable

@busches
Copy link
Contributor

busches commented Sep 14, 2015

If the build is already passing in stable, should it really be added to allow_failures?

@zckrs
Copy link
Collaborator

zckrs commented Sep 14, 2015

Already passing with error when install phantomjs

https://travis-ci.org/Swiip/generator-gulp-angular/jobs/80208134#L501

@@ -3,6 +3,7 @@ sudo: false
node_js:
- '0.10'
- '0.12'
- stable
- iojs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove iojs ?

@zckrs
Copy link
Collaborator

zckrs commented Sep 15, 2015

Build with node v4 stable fail because socket.io must update depencie engine.io to 1.5.4

socketio/socket.io#2228
socketio/socket.io#2242
socketio/socket.io#2245
socketio/socket.io#2213

@Swiip
Copy link
Owner Author

Swiip commented Sep 16, 2015

Done

zckrs pushed a commit that referenced this pull request Sep 16, 2015
@zckrs zckrs merged commit 5d5d571 into master Sep 16, 2015
@zckrs zckrs deleted the node-4 branch October 19, 2015 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants