Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Test with Swift 5.3 on Linux #183

Merged
merged 7 commits into from
Sep 24, 2020
Merged

Test with Swift 5.3 on Linux #183

merged 7 commits into from
Sep 24, 2020

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Sep 18, 2020

I'm not sure if you'd like to test with both Swift 5.2 and 5.3 on Linux. As you're using a cache, I think it would be easier to test just with a single version, as it doesn't make sense to share that cache. Let me know if you'd prefer to test both versions after all with separate cache keys.

@MaxDesiatov
Copy link
Contributor Author

Of course, SwiftSyntax parser library isn't compatible 😞

@MaxDesiatov
Copy link
Contributor Author

This requires changes to swift-doc dependencies, I'll update those first...

@MaxDesiatov MaxDesiatov marked this pull request as draft September 18, 2020 21:50
@mattt
Copy link
Contributor

mattt commented Sep 18, 2020

@MaxDesiatov Thanks for getting a head start on this! A lot of the work I'd been wanting to do on swift-doc had been blocked on general availability of Swift 5.3, so I'm really excited for this to finally be coming in place.

I just pushed a few commits to test Swift 5.2 and 5.3 on CI for Linux and macOS (I'd like to keep support for 5.2 in the short term, to give folks some time to upgrade).

Edit Ah yikes, I didn't realize you were actively working on this, so apologies for meddling. I'll stay clear until this is ready to go.

@MaxDesiatov
Copy link
Contributor Author

Thanks! This now depends on NSHipster/SwiftSyntaxHighlighter#8

@mattt mattt marked this pull request as ready for review September 24, 2020 20:44
@mattt mattt merged commit dc1cac9 into SwiftDocOrg:master Sep 24, 2020
@mattt
Copy link
Contributor

mattt commented Sep 24, 2020

Thanks for your help with this, @MaxDesiatov! Glad to have this blocker out of the way so that we can target Swift 5.3 for future releases.

@MaxDesiatov MaxDesiatov deleted the patch-4 branch September 24, 2020 21:10
@MaxDesiatov
Copy link
Contributor Author

Thanks for finishing the PR!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants