Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dx-2311 migration guide continued #2101

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

arebra
Copy link
Member

@arebra arebra commented Feb 2, 2024

No description provided.

@arebra arebra requested a review from a team as a code owner February 2, 2024 08:45
@probot-autolabeler probot-autolabeler bot added the documentation Improvements or additions to documentation label Feb 2, 2024
"status," also expanding the range of values that are given to reflect more
accurately what stage the transaction is in.

**Initialized**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [remark-lint] reported by reviewdog 🐶
Don’t use emphasis to introduce a section, use a heading no-emphasis-as-heading remark-lint

remains applicable throughout the active period when the `paymentOrder` is open
for conversion into a payment by the payer.

**Paid**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [remark-lint] reported by reviewdog 🐶
Don’t use emphasis to introduce a section, use a heading no-emphasis-as-heading remark-lint

Additionally, `Paid` will be directly returned in the response when conducting
post-purchase actions and if there is an associated amount that has been paid.

**Aborted**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [remark-lint] reported by reviewdog 🐶
Don’t use emphasis to introduce a section, use a heading no-emphasis-as-heading remark-lint

within our domain. The latter scenario is applicable solely if you have
implemented a redirect integration.

**Failed**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [remark-lint] reported by reviewdog 🐶
Don’t use emphasis to introduce a section, use a heading no-emphasis-as-heading remark-lint

(Merchant Initiated Transactions) transactions and other server-to-server
requests. Please note that this condition may evolve in the future.

**Reversed**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [remark-lint] reported by reviewdog 🐶
Don’t use emphasis to introduce a section, use a heading no-emphasis-as-heading remark-lint

Payer identification (Checkin)

Checkin is no longer supported in its previous form. Payer identification now
**"instrumentMode"**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [remark-lint] reported by reviewdog 🐶
Don’t use emphasis to introduce a section, use a heading no-emphasis-as-heading remark-lint

feature from the regular menu, and in most cases, it will be returned as
`false`.

**“guestMode”**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [remark-lint] reported by reviewdog 🐶
Don’t use emphasis to introduce a section, use a heading no-emphasis-as-heading remark-lint

handling. Subscribe to this event in order to log actions that are happening in
the payment flow at Swedbank Pay.

**Events no longer needed and/or supported are:**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [remark-lint] reported by reviewdog 🐶
Don’t use emphasis to introduce a section, use a heading no-emphasis-as-heading remark-lint

@@ -197,9 +411,12 @@
}
}
}
```
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [remark-lint] reported by reviewdog 🐶
Missing code language flag fenced-code-flag remark-lint

{
"orderReference":"ABC123",
"paymentOrder": {
"id":"/psp/paymentorders/c3ac1392-35b0-43a6-8f27-08dbce43b47c",
"instrument":"Swish"
}
}
```
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [remark-lint] reported by reviewdog 🐶
Missing code language flag fenced-code-flag remark-lint

**Initialized**

This status is returned upon the initial creation of the `paymentOrder` and
remains applicable throughout the active period when the `paymentOrder` is open
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [alex] reported by reviewdog 🐶
Be careful with remains, it’s profane in some cases remains retext-profanities


**Aborted**

This value becomes accessible only following the execution of an `abort`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [alex] reported by reviewdog 🐶
Be careful with execution, it’s profane in some cases execution retext-profanities

request. This means you are already familiar with the structure, but the
difference now is that it also applies to the response for post-purchase
`Captures`, `Reversals`, and `Cancellations` will now be returned with the
intended response template provided by us. The information structure remains
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [alex] reported by reviewdog 🐶
Be careful with remains, it’s profane in some cases remains retext-profanities

@arebra arebra merged commit 9fd57a9 into develop Feb 2, 2024
20 of 24 checks passed
@arebra arebra deleted the feature/dx-2311_migration_guide_continued branch February 2, 2024 10:19
Copy link
Contributor

mergify bot commented Feb 2, 2024

Thank you @arebra for your contribution!

This was referenced Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant