Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SWUI-17][FEAT] - Create ButtonLink component #9

Merged
merged 13 commits into from
May 6, 2024
Merged

[SWUI-17][FEAT] - Create ButtonLink component #9

merged 13 commits into from
May 6, 2024

Conversation

ElRodrigote
Copy link
Collaborator

Fixes: SWUI-17

Description

  • Move the Button component and its story to its folder
  • Create the ButtonLink component and its story

Visual Evidence

image

@vercel Vercel
Copy link

vercel bot commented Apr 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swapr-ui-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 10:50am

@Diogomartf
Copy link
Contributor

Diogomartf commented Apr 26, 2024 •
edited
Loading

Related to styles, they seem to be broken.

image

ButtonLink is just a Button in terms of styles, the only difference is one is a link element and the other is a button element.

We're just doing 2 components to keep button simple, cause is already too big, adding that diff would add more complexity.

@Diogomartf Diogomartf changed the title [SWUI-17][FEAT] - Create ButtonLinkcomponent [SWUI-17][FEAT] - Create ButtonLink component Apr 30, 2024
@ElRodrigote ElRodrigote requested a review from Diogomartf April 30, 2024 15:36
@ElRodrigote ElRodrigote requested a review from berteotti May 3, 2024 13:08
berteotti
berteotti approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@berteotti berteotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, good job Rorry!

@ElRodrigote ElRodrigote merged commit f221dde into main May 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berteotti berteotti berteotti approved these changes

@Diogomartf Diogomartf Awaiting requested review from Diogomartf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ElRodrigote @Diogomartf @berteotti