Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SWUI-22][IMPROV] - Change color tiles to the left, to align it or use a grid #15

Conversation

ElRodrigote
Copy link
Collaborator

Fixes: SWUI-22

Description

  • Break the single long colors column into three columns
  • Switch color names and color samples from place
  • Filter out transparent and inherit colors

Visual Evidence

Screenshot 2024-06-04 at 13 57 45

How to test the changes

  1. Pull this branch
  2. Run the Website project locally
  3. Go to the main page
  4. The Colors section should be displaying a 3 column grid layout, with the color samples on the left and the color names on the right

…h color names and color samples from place
Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 3:12pm
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 3:12pm

@Diogomartf
Copy link
Contributor

Diogomartf commented Jun 4, 2024

Looks much better the color on the left. 👍

Let's give it more vertical space (y) between diff color sections.

image

title (add bit more space to bottom title) + colors (add more space) title + colors (add more space) title + colors ...

It would be nice to also add a divider (very light gray) between the sections.

@Diogomartf
Copy link
Contributor

It should be responsive, on mobile it should have only 1 column.

image

@ElRodrigote ElRodrigote merged commit 46ba7db into main Jun 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants