Add build:storybook task to turbo #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
berteotti
reviewed
May 15, 2024
package.json
Outdated
Comment on lines
17
to
19
| "build:ui": "turbo run build --filter=./packages/ui", | ||
| "build:storybook": "turbo run build:storybook --filter=./packages/ui", | ||
| "build:website": "turbo run build --filter=./apps/website", |
There was a problem hiding this comment.
Suggested change
| "build:ui": "turbo run build --filter=./packages/ui", | |
| "build:storybook": "turbo run build:storybook --filter=./packages/ui", | |
| "build:website": "turbo run build --filter=./apps/website", | |
| "build:ui": "turbo run build --filter=swapr-ui", | |
| "build:storybook": "turbo run build:storybook --filter=swapr-ui", | |
| "build:website": "turbo run build --filter=swapr-ui-website", |
This looks cleaner to me, what do you think?
berteotti
approved these changes
May 15, 2024
ElRodrigote
approved these changes
May 15, 2024
Diogomartf
force-pushed
the
fix-deploy-update-turbo
branch
from
631f274 to
6d6d9d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this helps fix the build on deploy
Now vercel does the 2 deploys.