add storybook basic setup #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berteotti
approved these changes
Apr 1, 2024
ElRodrigote
approved these changes
Apr 1, 2024
|
|
||
| // More on default export: https://storybook.js.org/docs/react/writing-stories/introduction#default-export | ||
| export default { | ||
| title: "Swapr-ui/Button", |
There was a problem hiding this comment.
Small think to bear in mind in future:
This title path groups the components, so if we keep pushing Swapr-ui/Button, there will be a big Swapr-ui folder in Storybook
IMHO this doesn't make much sense as we're in this repo. I'd use this grouping feature only if we have component groups either by functionality or design (for example atoms, molecules, etc).
There was a problem hiding this comment.
Makes sense, but for now, It's just to show case, so I'll keep it like it is. But I think you have experience in that and you can lead the storybook to put it neat. 🙌
Co-authored-by: Rorry <lil.rorry@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a basic setup just to get us started. We can use storybook to quickly build and test a component before publishing it.
We can also use it for docs.
I added an example of our Button component.