Default search lang #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the search functionality in `SearchView.java` to utilize a `ComboBox` instead of `LangComboBox`. Additionally, it adds a new feature for users to select a default search language. The selected language is saved into the settings in `Settings.java` and is applied each time the user employs the search function. This enhances the search results accuracy for users primarily reading in a specific language. In `SettingsView.java`, it also adds a ComboBox for users to select a default search language for their sessions. This should improve both code clarity and the user experience.
This commit replaces `settings.getDefaultSearchLang() != null && !settings.getDefaultSearchLang().isEmpty()` with `settings.hasDefaultSearchLang()` in `SearchView.java`. This change was made for better readability and maintenance of the code. The `hasDefaultSearchLang()` method has been updated in the `Settings.java` class to check for both null and empty values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives the option to set a Default Language which will be used when searching for Manga. This should improve the usability of the search feature.