Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
BUG: Let
elx::ConjugateGradientFRPR
override ITK's FRPROptimizer
`elx::ConjugateGradientFRPR` member functions GetValueAndDerivative and LineOptimize did originally override the corresponding virtual member functions of ITK's FRPROptimizer. This property was broken by a change in the signature of those ITK member functions: ITK commit InsightSoftwareConsortium/ITK@a088a95, "PERF: Changed to pass by reference for faster performance", 2008-04-23 This commit restores those "overrides", by adjusting the signature of the `elx::ConjugateGradientFRPR` member functions, in accordance with those ITK member functions. Bug found by macos-12/clang compiler warnings, like: > warning: 'elastix::ConjugateGradientFRPR::GetValueAndDerivative' hides overloaded virtual function [-Woverloaded-virtual] Note: These two `elx::ConjugateGradientFRPR` member functions don't seem to be tested at the CI, currently.
- Loading branch information