Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add user schema #13

Merged
merged 3 commits into from
Apr 18, 2022
Merged

feat: add user schema #13

merged 3 commits into from
Apr 18, 2022

Conversation

chirag0002
Copy link
Collaborator

For registration user schema has to be made for storing user details for further future verification and actions.
It contains details such as:

  • First Name
  • Last Name
  • User Name
  • E-mail
  • Phone No.
  • Date Of Birth
  • Country
  • Password
  • Confirm Password

Closes #8

@@ -19,4 +22,32 @@ Router.post("/check", async (req, res) => {
}
});

Router.post('/register', async (req,res) => {
console.log('inside register');

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid pushing unnecessary consoles.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed all unnecessary consoles.

console.log(err)
}
});

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try using comments for more user friendly experience.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are added to the codes where needed.

Copy link
Collaborator

@chandankumar1307 chandankumar1307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Owner

@SuperAayush SuperAayush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

__
sema-logo  Summary: 👌 This code looks good

@SuperAayush SuperAayush self-requested a review April 18, 2022 17:08
Copy link
Owner

@SuperAayush SuperAayush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__
sema-logo  Summary: 👌 This code looks good

@AayushShuk1a AayushShuk1a self-requested a review April 18, 2022 17:22
Copy link
Collaborator

@AayushShuk1a AayushShuk1a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

Copy link
Collaborator

@bhavyastar bhavyastar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chirag0002 chirag0002 merged commit 3ea8246 into main Apr 18, 2022
@SuperAayush SuperAayush deleted the chirag branch April 19, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] <user id schema>
5 participants