add bulk issuance service #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejash-jl
reviewed
Apr 19, 2023
| } | ||
| }{} | ||
|
|
||
| func updatePublicKeyFromKeycloak() error { |
There was a problem hiding this comment.
function name needs to be modified
services/bulk_issuance/db/db.go
Outdated
|
|
||
| var db *gorm.DB | ||
|
|
||
| type DBFiles struct { |
services/bulk_issuance/db/db.go
Outdated
| Date string | ||
| } | ||
|
|
||
| type DBFileData struct { |
| security: | ||
| - hasRole: [] | ||
| securityDefinitions: | ||
| hasRole: |
There was a problem hiding this comment.
we can use this right? instead of custom implementation,
https://github.com/egovernments/DIVOC/blob/main/interfaces/vaccination-api.yaml#L17
| produces: | ||
| - application/json | ||
| paths: | ||
| /v1/sample/{schemaName}: |
There was a problem hiding this comment.
should it be /v1/{schema-name}/sample-csv
| description: Not found | ||
| schema: | ||
| type: string | ||
| /v1/uploadFiles/{VCName}: |
| description: Internal Server Error | ||
| schema: | ||
| type: string | ||
| /v1/download/{id}: |
| return response | ||
| } | ||
|
|
||
| func addEntryForDbFilesToDatabase(rows [][]string, fileName string, data Scanner, principal *models.JWTClaimBody) (uint, error) { |
There was a problem hiding this comment.
move the below functionalities to service layer
| return false | ||
| } | ||
|
|
||
| func GetSchemaProperties(key string) ([]string, error) { |
There was a problem hiding this comment.
is this a util function? can it be part of registry service
| return totalSuccess, totalErrors, rows, nil | ||
| } | ||
|
|
||
| func appendErrorsToCurrentRow(res *http.Response, data *Scanner, lastColIndex int, currRow []string) []string { |
tejash-jl
reviewed
May 2, 2023
| RealmAccess map[string][]string `json:"realm_access"` | ||
| Scope string `json:"scope"` | ||
| PreferredUsername string `json:"preferred_username"` | ||
| FacilityCode string `json:"facility_code"` |
There was a problem hiding this comment.
we dont need facility code right?
tejash-jl
reviewed
May 2, 2023
services/bulk_issuance/db/db.go
Outdated
| db.AutoMigrate(&FileData{}) | ||
| } | ||
|
|
||
| func GetFileDataByIdAndUser(id int, userId string) (*FileData, error) { |
There was a problem hiding this comment.
you can apply the userId check in the query itself
Use userId to filter files for the same user in query itself rather than outside and Remove FacilityCode from the parsing of JWTClaim token
- update API specs - move custom implementation from swagger_gen resources to external class - remove unused code - fix test cases The custom implementation has been moved out of swagger_gen directory mainly because modifying existing specs will be more easier. JWTClaimBody is also autogenerated via swagger spec.
The above change is made to get to know if controllers object is directly used instead of using the reference variable
- update parsing schema properties from map to struct
- update getUploadItems to return only required data
- Update error payload to be json object
tejash-jl
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.