Update docs for AOI methods (#96)

* Fix names of faoi dictionaries in irradiance models * Start tutorial on using AOI losses * Updated AOI loss tutorial with lots of info * Fixes for the new tutorial after review * Add section on using the run functions * Typo fix * Clean up
SunPower · Nov 21, 2019 · 97b8945 · 97b8945
1 parent ffe0c02
commit 97b8945
Show file tree

Hide file tree

Showing 5 changed files with 2,270 additions and 5 deletions.
diff --git a/docs/sphinx/tutorials/Account_for_AOI_losses.ipynb b/docs/sphinx/tutorials/Account_for_AOI_losses.ipynb
diff --git a/docs/sphinx/tutorials/index.rst b/docs/sphinx/tutorials/index.rst
@@ -43,6 +43,7 @@ In the "full mode", ``pvfactors`` calculates the equilibrium of reflections betw
    Calculate_view_factors
    Run_full_timeseries_simulations
    Run_full_parallel_simulations
+   Account_for_AOI_losses
 
 
 Details on the "fast mode" simulations

diff --git a/docs/tutorials/Account_for_AOI_losses.ipynb b/docs/tutorials/Account_for_AOI_losses.ipynb
diff --git a/pvfactors/engine.py b/pvfactors/engine.py
@@ -235,7 +235,7 @@ def run_full_mode(self, fn_build_report=None):
         vf_aoi_matrix = (self.vf_calculator
                          .build_ts_vf_aoi_matrix(pvarray, rho_mat))
         pvarray.ts_vf_aoi_matrix = vf_aoi_matrix
-        # shape [n_surfaces, n_surfaces]
+        # shape [n_surfaces, n_timestamps]
         irradiance_abs_mat = (
             self.irradiance.get_summed_components(pvarray, absorbed=True))
         # Calculate absorbed irradiance

diff --git a/pvfactors/irradiance/models.py b/pvfactors/irradiance/models.py
@@ -61,8 +61,8 @@ def __init__(self, rho_front=0.01, rho_back=0.03, module_transparency=0.,
         """
         self.direct = dict.fromkeys(self.cats)
         self.total_perez = dict.fromkeys(self.cats)
-        self.faoi_front = dict.fromkeys(self.cats)
-        self.faoi_back = dict.fromkeys(self.cats)
+        self.faoi_front = dict.fromkeys(self.irradiance_comp)
+        self.faoi_back = dict.fromkeys(self.irradiance_comp)
         self.faoi_ground = None
         self.module_transparency = module_transparency
         self.module_spacing_ratio = module_spacing_ratio
@@ -453,8 +453,8 @@ def __init__(self, horizon_band_angle=DEFAULT_HORIZON_BAND_ANGLE,
         self.circumsolar = dict.fromkeys(self.cats)
         self.horizon = dict.fromkeys(self.cats)
         self.total_perez = dict.fromkeys(self.cats)
-        self.faoi_front = dict.fromkeys(self.cats)
-        self.faoi_back = dict.fromkeys(self.cats)
+        self.faoi_front = dict.fromkeys(self.irradiance_comp)
+        self.faoi_back = dict.fromkeys(self.irradiance_comp)
         self.faoi_ground = None
         self.horizon_band_angle = horizon_band_angle
         self.circumsolar_angle = circumsolar_angle