-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cascadingfilterprocessor): prevent overriding metrics in cascading filter processor - add processor tag #539
Conversation
I think it should be named |
Also please rename all |
cc9af28
to
b1c381b
Compare
Please use conventional commits (at least as PR name, so it will be used while squashing and merging) and also please make Ci to be happy 🤗 |
We should just enable https://github.com/zeke/semantic-pull-requests in this repo, just as we have in the Helm chart one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two requests:
- I think this should have a changelog entry.
- Can you squash your commits into one?
LGTM otherwise.
5c710ab
to
665bb07
Compare
665bb07
to
71e2df0
Compare
71e2df0
to
cea6353
Compare
CHANGELOG.md
Outdated
@@ -14,10 +14,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
### Fixed | |||
|
|||
- fix(sumologicexporter): treat resource attributes as fields for otlp #536 | |||
- fix(cascadingfilterprocessor): prevent overriding metrics in cascading filter processor - add processor tag #539 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to keep this type of links (i.e. #539
which wouldn't work outside of Github vs embedded markdown links [#539][#539]
) ?
@SumoLogic/open-source-collection-team ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd personally prefer normal MD links that will work locally as well.
@SumoLogic/open-source-collection-team Do you have any idea what is wrong with the check: PRs checks / markdown-link-check (pull_request)? How to fix this? |
It seems its a known issue with the latest version: gaurav-nelson/github-action-markdown-link-check#127 Let's try to rerun it, it should work just fine as v1 was pinned to previous working version (1.0.13 instead of broken 1.0.14) |
I reran the link check and it passed. @dmolenda-sumo you just need to rebase on main and we should be good to merge. |
…g filter processor - add processor tag
54b0bf8
to
c877137
Compare
…g filter processor - add processor tag (#539)
When two cascading filter processor instances were running on one collector, the metrics values were overridden. Adding the instance_name tag fixes this issue