chore: lint and format using black and isort #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
force-pushed
the
ci/formatting
branch
4 times, most recently
from
7e51f89 to
b37b5df
Compare
swiatekm
force-pushed
the
ci/formatting
branch
from
b37b5df to
b2b3672
Compare
They had an implicit dependency on particular import ordering. I made it explicit. |
kasia-kujawa
approved these changes
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make formatting and import ordering consistent by using black and isort. I had to split the requirements file, as black doesn't actually run on Python 2, though it does format Python 2 files. This meant that the lint and test jobs in GHA had to run with different dependencies installed.