Send all metrics and remove typesDB config option #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 7, 2021 12:48
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
changed the title
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
force-pushed
the
drosiek-send-all-types
branch
from
b24a120 to
9c3b3d6
Compare
Closed
gizmo-rt
reviewed
Sep 8, 2021
| @@ -51,7 +51,12 @@ def write_callback(self, raw_data, _=None): | |||
| Write callback | |||
| """ | |||
|
|
|||
| metrics = convert_to_metrics(raw_data, self.met_config.types) | |||
| try: | |||
| data_set = self.collectd.get_dataset(raw_data.type) | |||
There was a problem hiding this comment.
Do we need to handle the None case as well as mentioned in get_datset return values here https://collectd.org/documentation/manpages/collectd-python.5.shtml ?
There was a problem hiding this comment.
min and max has not been taken into account so far, and in case dataset gets invalid metric type it raises TypeError
There was a problem hiding this comment.
I open new issue to track this: #36
kasia-kujawa
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
collectd.get_datasetto obtain dataset definition instead of usinttypesDb