Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old metadata conversion #6

Merged
merged 16 commits into from
Sep 16, 2024
Merged

Old metadata conversion #6

merged 16 commits into from
Sep 16, 2024

Conversation

Apolixit
Copy link
Member

This PR handle conversion from MetadataV9/10/11/12/13 to V14
A lot of manual mapping has been done, so now we need to try it in real use case and do some adaptations if needed.

Features added :

  • Convert old metadata to v14
  • Convert v14 to MetaData.cs class from NET.API (to keep compatibility with the NET.Toolchain)
  • Refacto MetadataService to a static class, because this is just algorithm on metadata and nothing has to be persisted, so no need to instanciate this

Apolixit added 16 commits August 2, 2024 23:03
@Apolixit
WIP Converter v9 --> v13 to v14
d1af0b8
@Apolixit
WIP conversion
3d0cdf4
@Apolixit
WIP 3 pallets ok
b810cba
@Apolixit
WIP + add some basic tuple creation if not exists
6d47426
@Apolixit
Metadata v11 version 1 conversion ok
32b5145
@Apolixit
WIP
f7cd147
@Apolixit
The 27 versions < v14 conversion ok
d10c86b
@Apolixit
Some refacto
180acb7
@Apolixit
Upgrade Substrate.NET.API version + add mapping override index tracking
c1f28d1
@Apolixit
Bump to 0.9.24-rc5
9e7b471
@Apolixit
Remove uncessary MetadataService and convert it to a simple class wit…
bc5e0f4 
…h static method
@Apolixit
Remove Conversion projects which are not necessary anymore
13d715a
@Apolixit
Merge remote-tracking branch 'origin/master' into spike/metadata-convert
14783d9 
# Conflicts:
#	Substrate.NET.Metadata.Tests/MetadataServiceV10Test.cs
#	Substrate.NET.Metadata.Tests/MetadataServiceV11Test.cs
#	Substrate.NET.Metadata.Tests/MetadataServiceV12Test.cs
#	Substrate.NET.Metadata.Tests/MetadataServiceV13Test.cs
#	Substrate.NET.Metadata.Tests/MetadataServiceV14Test.cs
#	Substrate.NET.Metadata.Tests/MetadataServiceV15Test.cs
#	Substrate.NET.Metadata.Tests/MetadataServiceV9Test.cs
#	Substrate.NET.Metadata.Tests/Substrate.NET.Metadata.Tests.csproj
#	Substrate.NET.Metadata/Substrate.NET.Metadata.csproj
#	Substrate.NET.Metadata/V15/RuntimeMetadataV15.cs
@Apolixit
Light fix post merge
c07aa2f
@Apolixit
Add Encode() unit test + check if well implemented
f70b10a
@Apolixit
Small unit tests + light refacto + bump version
2669f8c
@Apolixit Apolixit added the enhancement New feature or request label Sep 15, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
12.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Apolixit Apolixit changed the title Spike/metadata convert Old metadata conversion Sep 15, 2024
@Apolixit Apolixit merged commit f713645 into master Sep 16, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkfriend77 darkfriend77 darkfriend77 approved these changes

@RostislavLitovkin RostislavLitovkin Awaiting requested review from RostislavLitovkin

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Apolixit @darkfriend77