Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add optional followlinks to datasamples spec #426

Merged
merged 5 commits into from
Aug 21, 2024
Merged

feat: add optional followlinks to datasamples spec #426

merged 5 commits into from
Aug 21, 2024

Conversation

ThibaultFy
Copy link
Member

@ThibaultFy ThibaultFy commented Aug 20, 2024 •
edited
Loading

Related issue

closes fl-1714

Summary

Notes

Please check if the PR fulfills these requirements

  • If necessary, the changelog has been updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The commit message follows the conventional commit specification
  • For any breaking changes, companion PRs have been opened on the following repositories:

@ThibaultFy
chore: add optional followlinks to datasampels
d8521f6 
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy
chore: add optional followlinks to datasampels
6972912 
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy ThibaultFy marked this pull request as ready for review August 21, 2024 07:30
@ThibaultFy ThibaultFy requested a review from a team as a code owner August 21, 2024 07:30
@linear Linear
Copy link

linear bot commented Aug 21, 2024

FL-1714 Allow lo register folder with recursive symlinks

thbcmlowk
thbcmlowk reviewed Aug 21, 2024
View reviewed changes
Copy link
Contributor

@thbcmlowk thbcmlowk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, LGTM! One suggestion tho would be to add a "use at your own risk" warning when instantiating the DataSampleSpec. Wdyt? cf:

Note Be aware that setting followlinks to True can lead to infinite recursion if a link points to a parent directory of itself. walk() does not keep track of the directories it visited already.

@ThibaultFy ThibaultFy changed the title chore: add optional followlinks to datasamples spec feat: add optional followlinks to datasamples spec Aug 21, 2024
@ThibaultFy
chore: add warning
2d14342 
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy ThibaultFy requested a review from thbcmlowk August 21, 2024 09:37
@ThibaultFy
chore: add warning
d4f94dc 
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
@ThibaultFy
chore: add warning
01c2325 
Signed-off-by: ThibaultFy <thibault.fouqueray@gmail.com>
thbcmlowk
thbcmlowk approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@thbcmlowk thbcmlowk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ThibaultFy ThibaultFy merged commit ce8452a into main Aug 21, 2024
6 checks passed
@ThibaultFy ThibaultFy deleted the chore/allow-recursive-symlinks branch August 21, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thbcmlowk thbcmlowk thbcmlowk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThibaultFy @thbcmlowk