Refactor Github Actions #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deathaxe
force-pushed
the
feat/refactor-actions
branch
13 times, most recently
from
0da402f to
464db7f
Compare
They are no longer used. 1. To generate code coverage reports latest available coverage package is installed as library by ST (requires Package Control!). Coverage reports are created from within ST's plugin environment. 2. Coverage reports are to be uploaded via via codecov action, which has to deal with installing required coverage python packages itself.
Package Control is configured not to auto-update or touch any package. Restoring something after installing Package Control is obsolete.
deathaxe
force-pushed
the
feat/refactor-actions
branch
9 times, most recently
from
1ea6e64 to
2b7b46a
Compare
Starting and stopping ST is just a waste of time. It will be started to install Package Control.
1. Allowing to not install UnitTesting is odd as tests won't run without it. 2. Installing a version which is unrelated with current action revision is also odd and confusing. If a certain version is desired for CI, it can be selected via `SublimeText/UnitTesting/actions/setup@<revision>`. The `setup` action always installs the UnitTesting package, which is bundled with the action's revision, if UnitTesting is not the checked out package or hasn't been installed as extra-package. That's possible as the action is part of UnitTesting package. The package doesn't need to be re-downloaded.
deathaxe
force-pushed
the
feat/refactor-actions
branch
from
2b7b46a to
99f2489
Compare
This commit prevents Package Control.sublime-package from being downloaded and installed, if Package Control folder already exists as extracted package. This may be the case if it is the package to test or was installed via `extra-packages` input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.