Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PackageDev] File conversion unsuccessful. (yaml -> plist) but conversion was success #55

Closed
sspkmnd opened this issue Apr 1, 2015 · 7 comments
Labels
Milestone

Comments

@sspkmnd
Copy link
Contributor

sspkmnd commented Apr 1, 2015

I'm using your package to develop syntax highlighting, and when i convert yaml to plist using build system of the package it puts that message to Sublime console

[PackageDev] File conversion unsuccessful. (yaml -> plist)

but conversion was success. Then I find out in the package source following line of code which can produce that message I think.

https://github.com/SublimeText/AAAPackageDev/blob/b1e61d9c404d101c86aef0744d5c3b7a773c684a/file_conversion.py#L242-L243

So, is it feature of the package to print unsuccess message when convertion was success?

@FichteFoll
Copy link
Member

Thanks for the report. I just mixed the output message and made it display the opposite result in that message ("un" if success else "").

I don't think I'll release a bugfix for just this, so I'll allocate some time in the near future and fix a few other things as well.

@FichteFoll FichteFoll added this to the 1.0.7 milestone Apr 22, 2015
@chiefy
Copy link

chiefy commented Jun 25, 2015

👍 as a n00b, this was kind of confusing and had me wondering how to figure out what was wrong w/ my definition file.

@dalboris
Copy link

dalboris commented Jul 8, 2015

I think you should definitely submit a bugfix for this, especially if it's an easy fix. The message makes us think something's wrong, and loses time trying to troubleshoot what's wrong.

@FichteFoll
Copy link
Member

I see this is causing a few problems for users, so I'll raise this in my priority list. Look for a fix on the weekend.

FichteFoll added a commit that referenced this issue Jul 13, 2015
@FichteFoll
Copy link
Member

Fixed via #62.

Edit: And changed later, via 30e1568.

@chiefy
Copy link

chiefy commented Jul 13, 2015

Thanks @FichteFoll ! 👍 🍻

@dalboris
Copy link

Great, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants