Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solidify usage with multiple views into a file #142

Open
FichteFoll opened this issue Sep 15, 2017 · 2 comments
Open

Solidify usage with multiple views into a file #142

FichteFoll opened this issue Sep 15, 2017 · 2 comments

Comments

@FichteFoll
Copy link
Member

None of the event listeners were tested with multiple views into the same file. Also, none of the ViewEventListeners implement applies_to_primary_view_only, which returns True by default.

This is low priority but at least it's documented now.

@deathaxe
Copy link
Member

deathaxe commented Jan 7, 2019

Just wondered why completions didn't work for Sublime Syntax when I found it was a secondary view. Adding applies_to_primary_view_only() fixes the issue and seems to works well so far.

class SyntaxDefCompletionsListener(sublime_plugin.ViewEventListener):

    @classmethod
    def applies_to_primary_view_only(cls):
        return False

FichteFoll added a commit that referenced this issue Jan 15, 2019
@FichteFoll
Copy link
Member Author

FichteFoll commented Jan 15, 2019

Just adding the callback didn't work for:

  • SyntaxTestHighlighterListener
  • SyntaxDefRegexCaptureGroupHighlighter

But did work for:

  • SettingsListener (c42fd54)
  • ColorSchemeCompletionsListener (c42fd54)
  • SyntaxDefCompletionsListener (fef2f7a)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants